From 6791ac0a472cdc968f8d97187c3a8a3d1b272341 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Juan=20Jos=C3=A9=20Arboleda?= Date: Thu, 19 Mar 2020 16:35:13 -0500 Subject: [PATCH] src: clean v8 namespaces in env.cc file PR-URL: https://github.com/nodejs/node/pull/32374 Reviewed-By: James M Snell Reviewed-By: Michael Dawson Reviewed-By: David Carlier Reviewed-By: Anna Henningsen Reviewed-By: Luigi Pinca --- src/env.cc | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/env.cc b/src/env.cc index 2cd3a9258ecfed..7d76ee8186ad28 100644 --- a/src/env.cc +++ b/src/env.cc @@ -64,9 +64,9 @@ std::vector IsolateData::Serialize(SnapshotCreator* creator) { // but that's not part of the V8 API contract so we use an array // just to be safe. -#define VP(PropertyName, StringValue) V(v8::Private, PropertyName) -#define VY(PropertyName, StringValue) V(v8::Symbol, PropertyName) -#define VS(PropertyName, StringValue) V(v8::String, PropertyName) +#define VP(PropertyName, StringValue) V(Private, PropertyName) +#define VY(PropertyName, StringValue) V(Symbol, PropertyName) +#define VS(PropertyName, StringValue) V(String, PropertyName) #define V(TypeName, PropertyName) \ indexes.push_back(creator->AddData(PropertyName##_.Get(isolate))); PER_ISOLATE_PRIVATE_SYMBOL_PROPERTIES(VP) @@ -84,9 +84,9 @@ void IsolateData::DeserializeProperties(const std::vector* indexes) { size_t i = 0; HandleScope handle_scope(isolate_); -#define VP(PropertyName, StringValue) V(v8::Private, PropertyName) -#define VY(PropertyName, StringValue) V(v8::Symbol, PropertyName) -#define VS(PropertyName, StringValue) V(v8::String, PropertyName) +#define VP(PropertyName, StringValue) V(Private, PropertyName) +#define VY(PropertyName, StringValue) V(Symbol, PropertyName) +#define VS(PropertyName, StringValue) V(String, PropertyName) #define V(TypeName, PropertyName) \ do { \ MaybeLocal field = \ @@ -1011,7 +1011,7 @@ Environment* Environment::worker_parent_env() const { void MemoryTracker::TrackField(const char* edge_name, const CleanupHookCallback& value, const char* node_name) { - v8::HandleScope handle_scope(isolate_); + HandleScope handle_scope(isolate_); // Here, we utilize the fact that CleanupHookCallback instances // are all unique and won't be tracked twice in one BuildEmbedderGraph // callback.