New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix occasional failure in refute_equal #12

Merged
merged 1 commit into from Jan 6, 2015

Conversation

Projects
None yet
2 participants
@merrilymeredith
Contributor

merrilymeredith commented Jan 4, 2015

Hi, I'm participating in the 2015 CPAN Pull Request Challenge, and my assignment for January was Test::Mini. As it turns out, I'm already a fan of minitest, and I think it's really neat that you brought yard over too.

This pull request fixes an occasional test failure when comparing hashrefs with refute_equal; it wasn't sorting keys in the same way as assert_equal.

I believe this fixes Issue #11, which just happens to have confusing output in the test report because of deprecation warnings.

I do have a few other small changes I can submit in another PR, if you don't mind. Thank you!

pvande added a commit that referenced this pull request Jan 6, 2015

Merge pull request #12 from merrilymeredith/test-cleanup
Fix occasional failure in refute_equal

@pvande pvande merged commit cd5d5eb into pvande:master Jan 6, 2015

@pvande

This comment has been minimized.

Show comment
Hide comment
@pvande

pvande Jan 6, 2015

Owner

Thanks so much! I'm somewhat ashamed to admit that my Perl projects have fallen by the wayside, but it's great to have people continuing to invest in them. 😄

I would love to see the other changes you were working on!

Owner

pvande commented Jan 6, 2015

Thanks so much! I'm somewhat ashamed to admit that my Perl projects have fallen by the wayside, but it's great to have people continuing to invest in them. 😄

I would love to see the other changes you were working on!

@merrilymeredith merrilymeredith deleted the merrilymeredith:test-cleanup branch Jan 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment