New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need better error message with check_for_collision #149

Closed
pvcraven opened this Issue Dec 5, 2017 · 2 comments

Comments

Projects
1 participant
@pvcraven
Owner

pvcraven commented Dec 5, 2017

If a new programmer calls check_for_collision instead of check_for_collision_with_list, the error generated is:

AttributeError: 'SpriteList' object has no attribute 'collision_radius'

That's not intuitive. Come up with a better error message.

pvcraven added a commit that referenced this issue Dec 5, 2017

Come up with a better error message for #149. Not as easy as just doi…
…ng type-checking because that causes a big performance hit. This seems to work ok.

@pvcraven pvcraven self-assigned this Dec 5, 2017

@pvcraven pvcraven added the enhancement label Dec 5, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 5, 2017

Owner

Can't just be a better error message, has to perform well too.

Owner

pvcraven commented Dec 5, 2017

Can't just be a better error message, has to perform well too.

@pvcraven pvcraven added this to Done in Release 1.2.3 Dec 5, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 21, 2017

Owner

Done and closed with release 1.2.3.

Owner

pvcraven commented Dec 21, 2017

Done and closed with release 1.2.3.

@pvcraven pvcraven closed this Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment