New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve wildcard imports #44

Closed
pvcraven opened this Issue Jun 2, 2016 · 6 comments

Comments

Projects
3 participants
@pvcraven
Owner

pvcraven commented Jun 2, 2016

Pylint complains because files like init.py are doing "import *" when they should not be doing wildcard imports.

@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Nov 16, 2016

Collaborator

Not sure what you'd like to do on this. It's stated quite emphatically that wildcard imports are to be avoided in nearly all cases. I think you're trying to flatten the namespace for your student developers, without putting everything in one file.

My guess, two alternatives:

  • We make their lives a little harder by making them do the full import
  • We make our lives a little harder by exporting each import one-by-one, manually, instead of by wildcard
Collaborator

pauleveritt commented Nov 16, 2016

Not sure what you'd like to do on this. It's stated quite emphatically that wildcard imports are to be avoided in nearly all cases. I think you're trying to flatten the namespace for your student developers, without putting everything in one file.

My guess, two alternatives:

  • We make their lives a little harder by making them do the full import
  • We make our lives a little harder by exporting each import one-by-one, manually, instead of by wildcard
@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Nov 16, 2016

Collaborator

As a note, in init, you do:

import arcade.color
import arcade.key

from arcade.application import *

Can we change the first two to match the last one? PyCharm gets confused and can't autocomplete arcade.color.

Collaborator

pauleveritt commented Nov 16, 2016

As a note, in init, you do:

import arcade.color
import arcade.key

from arcade.application import *

Can we change the first two to match the last one? PyCharm gets confused and can't autocomplete arcade.color.

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Nov 25, 2017

Owner

Is this still an issue? It seems to auto-complete for me ok right now when I use arcade.color.

Owner

pvcraven commented Nov 25, 2017

Is this still an issue? It seems to auto-complete for me ok right now when I use arcade.color.

@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Nov 27, 2017

Collaborator
Collaborator

pauleveritt commented Nov 27, 2017

@pvcraven pvcraven self-assigned this Dec 10, 2017

@pvcraven pvcraven added the bug label Dec 10, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 10, 2017

Owner

Ok, think I figured this out.

Owner

pvcraven commented Dec 10, 2017

Ok, think I figured this out.

pvcraven added a commit that referenced this issue Dec 10, 2017

Issue #44. Imports not working quite right. Auto-complete on PyCharm …
…isn't working for arcade.color and arcade.key

@pvcraven pvcraven added this to Done in Release 1.2.3 Dec 10, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 21, 2017

Owner

Done and closed with release 1.2.3.

Owner

pvcraven commented Dec 21, 2017

Done and closed with release 1.2.3.

@pvcraven pvcraven closed this Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment