New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quick running via -m #84

Closed
pauleveritt opened this Issue Nov 19, 2016 · 10 comments

Comments

Projects
2 participants
@pauleveritt
Collaborator

pauleveritt commented Nov 19, 2016

Two interesting cases. First, was someone able to get arcade installed correctly? Sure would be nice to have a very easy way to find out. For example, python3 -m arcade.hello which might launch a window, do a test for Pillow and avbin etc.

Next, people want to have a nice first experience. Instead of making them cut-and-paste an example then run it, same as the above: python -m arcade.demo.

Some things to think about:

  • Do we want just one sexy demo, several, or all of the examples?
  • Perhaps we should make a different thing to install, e.g. pip install arcade_gamepack which has a dependency on arcade, and they can do python3 -m arcade_gamepack.asteroid. If we did that, we might want to look at a pyarcade github organization for various repos.
@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Jun 23, 2017

Owner

We could move the "examples" directory to "arcade/examples" enabling python -m arcade.examples.myexample. After this, we'd need to:

  • Update documentation, so that it points to the new folder
  • Update conf file to include the image and sound folder contents

A demo would be nice, not sure what that would entail. But making the examples easier to run would be a nice improvement,

Owner

pvcraven commented Jun 23, 2017

We could move the "examples" directory to "arcade/examples" enabling python -m arcade.examples.myexample. After this, we'd need to:

  • Update documentation, so that it points to the new folder
  • Update conf file to include the image and sound folder contents

A demo would be nice, not sure what that would entail. But making the examples easier to run would be a nice improvement,

@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Jun 23, 2017

Collaborator
Collaborator

pauleveritt commented Jun 23, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Jun 23, 2017

Owner

Sounds great. An easy-to-use demo / hello world in the base package also sounds great.

Owner

pvcraven commented Jun 23, 2017

Sounds great. An easy-to-use demo / hello world in the base package also sounds great.

@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Jul 16, 2017

Collaborator

@pvcraven When you say "Update conf file to include the image and sound folder contents", I think you mean that we need to add a MANIFEST.in and add include_package_data=True in setup.py, correct?

Collaborator

pauleveritt commented Jul 16, 2017

@pvcraven When you say "Update conf file to include the image and sound folder contents", I think you mean that we need to add a MANIFEST.in and add include_package_data=True in setup.py, correct?

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Jul 16, 2017

Owner

Probably. Not sure off-hand what is needed, but that sounds right. Basically whatever is required so that the users have the sounds and images, otherwise it the demos won't be nearly as exciting.

Owner

pvcraven commented Jul 16, 2017

Probably. Not sure off-hand what is needed, but that sounds right. Basically whatever is required so that the users have the sounds and images, otherwise it the demos won't be nearly as exciting.

@pvcraven pvcraven added this to Possible in Release 1.2.3 Dec 5, 2017

@pvcraven pvcraven moved this from Possible to In Progress in Release 1.2.3 Dec 10, 2017

@pvcraven pvcraven assigned pvcraven and unassigned pauleveritt Dec 10, 2017

pvcraven added a commit that referenced this issue Dec 10, 2017

pvcraven added a commit that referenced this issue Dec 10, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 10, 2017

Owner

I have no idea how to manage the images and sound resources properly.

Owner

pvcraven commented Dec 10, 2017

I have no idea how to manage the images and sound resources properly.

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 10, 2017

Owner

Putting this in the __init__() sets the working directory to where the file is:

    file_path = os.path.dirname(os.path.abspath(__file__))
    os.chdir(file_path)

But we aren't distributing the images and sounds with the package yet.

Owner

pvcraven commented Dec 10, 2017

Putting this in the __init__() sets the working directory to where the file is:

    file_path = os.path.dirname(os.path.abspath(__file__))
    os.chdir(file_path)

But we aren't distributing the images and sounds with the package yet.

@pauleveritt

This comment has been minimized.

Show comment
Hide comment
@pauleveritt

pauleveritt Dec 10, 2017

Collaborator
Collaborator

pauleveritt commented Dec 10, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 10, 2017

Owner

I think I'm getting a workable solution for this.

Owner

pvcraven commented Dec 10, 2017

I think I'm getting a workable solution for this.

pvcraven added a commit that referenced this issue Dec 10, 2017

pvcraven added a commit that referenced this issue Dec 10, 2017

pvcraven added a commit that referenced this issue Dec 11, 2017

pvcraven added a commit that referenced this issue Dec 20, 2017

@pvcraven pvcraven moved this from In Progress to Done in Release 1.2.3 Dec 20, 2017

@pvcraven

This comment has been minimized.

Show comment
Hide comment
@pvcraven

pvcraven Dec 21, 2017

Owner

Done and closed with release 1.2.3.

Owner

pvcraven commented Dec 21, 2017

Done and closed with release 1.2.3.

@pvcraven pvcraven closed this Dec 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment