New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SpriteList.move() code needs to be cleaned up #171

Merged
merged 2 commits into from Dec 25, 2017

Conversation

Projects
2 participants
@Aareon
Contributor

Aareon commented Dec 23, 2017

#169

Apart from this, I don't really see what else I can change without breaking things

SpriteList.move() code needs to be cleaned up
#169

Apart from this, I don't really see what else I can change without breaking things
@@ -678,8 +676,6 @@ def move(self, change_x: float, change_y: float):
sprite.center_y += change_y

This comment has been minimized.

@pvcraven

pvcraven Dec 25, 2017

Owner

I think the code from lines 659 to 671 just need to go away?

@pvcraven

pvcraven Dec 25, 2017

Owner

I think the code from lines 659 to 671 just need to go away?

As you wish
Deleted lines 659-671

@pvcraven pvcraven merged commit af8a110 into pvcraven:master Dec 25, 2017

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details

@pvcraven pvcraven added this to Done in Release 1.2.5 Dec 29, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment