Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing site.getsitepackages attribute in sound.py for virtualenv compatibility. #216

Merged
merged 1 commit into from May 26, 2018

Conversation

3 participants
@r0the
Copy link
Contributor

r0the commented May 25, 2018

With this change, sound.py will not crash when executed in virtualenv. virtualenv is used by PyInstaller.

See issue #215.

@pvcraven pvcraven merged commit b2d1a78 into pvcraven:master May 26, 2018

1 check failed

continuous-integration/appveyor/pr AppVeyor build failed
Details

@pvcraven pvcraven added the bug label May 26, 2018

@pvcraven pvcraven added this to the 1.3.4 milestone May 26, 2018

@pvcraven

This comment has been minimized.

Copy link
Owner

pvcraven commented May 26, 2018

Thanks!

@pvcraven pvcraven added this to In progress in Release 1.3.4 May 26, 2018

@pvcraven pvcraven moved this from In progress to Done in Release 1.3.4 May 27, 2018

@pauleveritt

This comment has been minimized.

Copy link
Collaborator

pauleveritt commented May 27, 2018

Just ran into this with my son.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.