Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace all instances of .ix #322

Closed
wholmgren opened this issue May 4, 2017 · 4 comments · Fixed by #328
Closed

replace all instances of .ix #322

wholmgren opened this issue May 4, 2017 · 4 comments · Fixed by #328

Comments

@wholmgren
Copy link
Member

Pandas 0.20 deprecates the .ix indexer and we need to make a handful of minor changes to stay current.

https://github.com/pvlib/pvlib-python/search?utf8=✓&q=.ix&type=

http://pandas-docs.github.io/pandas-docs-travis/whatsnew.html#whatsnew-0200-api-breaking-deprecate-ix

I'd welcome a PR for this.

@wholmgren wholmgren added this to the 0.4.5 milestone May 4, 2017
@morrme
Copy link

morrme commented May 4, 2017

What do you want to change the references to: .loc or .iloc ? Seems like they should be .loc but I'd rather you make the call 👍

@cwhanse
Copy link
Member

cwhanse commented May 5, 2017 via email

@adriesse
Copy link
Member

adriesse commented May 5, 2017

Are these methods ok?

df.column_name.[row_number]
df.column_name.iloc[row_number]
df.iloc[row_number].column_name

@wholmgren
Copy link
Member Author

In timetimezones.rst, tmy3_data.ix[0:3, ['GHI', 'DNI', 'AOD']] becomes tmy3_data[tmy3_data.index[0:3], 'GHI', 'DNI', 'AOD']

In forecast.py, I think you can simply use [self.output_variables].

I think the case in irradiance.py will work with loc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants