Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update forecast.HRRR model name to match server update #1292

Merged
merged 2 commits into from Aug 26, 2021

Conversation

kahemker
Copy link
Contributor

@kahemker kahemker commented Aug 25, 2021

The HRRR CONUS 2.5km forecast model data name has changed.

  • Closes HRRR CONUS 2.5km Forecast Model Name has changed #1291
  • I am familiar with the contributing guidelines
  • Tests added
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels and Milestone are assigned to the Pull Request and linked Issue.
  • Tests are not added, but the existing test_forecast.py model() function now works for HRRR
  • No API Changes
  • No additional documentation. I just updated the name of the HRRR model forecast string
  • I'm not sure exactly what I should do to the "what's new" file... sorry. Edit: Updated the appropriate "what's new" file

The HRRR CONUS 2.5km forecast model data name has changed.
@wholmgren
Copy link
Member

wholmgren commented Aug 25, 2021

Thanks @kahemker. In the bug fixes section of this file you could add

* Fixed :py:class:`~pvlib.forecast.HRRR` by changing model name to reflect change on the server. (:issue:`1291`, :pull:`1292`)

Update v0.9.0.rst with bug fix documentation
@kahemker
Copy link
Contributor Author

Just pushed another commit with the change to the "what's new" documentation. Let me know if I need to update anything else.

@wholmgren wholmgren changed the title Update forecast.py Update forecast.HRRR model name to match server update Aug 26, 2021
@wholmgren wholmgren added this to the 0.9.0 milestone Aug 26, 2021
@wholmgren wholmgren merged commit c1bbf71 into pvlib:master Aug 26, 2021
@wholmgren
Copy link
Member

Thanks again @kahemker!

@kahemker kahemker deleted the hrrr-name-change branch August 15, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HRRR CONUS 2.5km Forecast Model Name has changed
2 participants