From fdbaec301d3dc202b7857692789688551982fe89 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Mon, 8 Dec 2025 10:02:10 -0700 Subject: [PATCH 1/4] correct argument and value order --- tests/ivtools/test_sde.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/ivtools/test_sde.py b/tests/ivtools/test_sde.py index a465d448c4..079dad2091 100644 --- a/tests/ivtools/test_sde.py +++ b/tests/ivtools/test_sde.py @@ -57,18 +57,18 @@ def test_fit_sandia_simple_bad_iv(get_bad_iv_curves): (np.array([3., 2.9, 2.8, 2.7, 2.6, 2.5, 2.4, 1.7, 0.8, 0.]), np.array([0., 0.2, 0.4, 0.6, 0.8, 1., 1.2, 1.4, 1.45, 1.5]), 10., - (2.3392, 11.6865, -.232, -.2596, -.7119)), + (2.3392, 11.6865, -.2596, -.232, -.7119)), (np.array( [5., 4.9, 4.8, 4.7, 4.6, 4.5, 4.4, 4.3, 4.2, 4.1, 4., 3.8, 3.5, 1.7, 0.]), np.array( [0., .1, .2, .3, .4, .5, .6, .7, .8, .9, 1., 1.1, 1.18, 1.2, 1.22]), 15., - (-22.0795, 27.1196, -4.2076, -.0056, -.0498))]) + (-22.0795, 27.1196, -.0056, -4.2076, -.0498))]) def test__fit_sandia_cocontent(i, v, nsvth, expected): # test confirms agreement with Matlab code. The returned parameters # are nonsense - iph, io, rsh, rs, n = sde._fit_sandia_cocontent(v, i, nsvth) + iph, io, rs, rsh, n = sde._fit_sandia_cocontent(v, i, nsvth) np.testing.assert_allclose(iph, np.array(expected[0]), atol=.0001) np.testing.assert_allclose(io, np.array([expected[1]]), atol=.0001) np.testing.assert_allclose(rs, np.array([expected[2]]), atol=.0001) From 40d141c34c9349101105dfb341f5b2e57e1ed83c Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Mon, 8 Dec 2025 10:07:55 -0700 Subject: [PATCH 2/4] whatsnew --- docs/sphinx/source/whatsnew/v0.13.2.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.13.2.rst b/docs/sphinx/source/whatsnew/v0.13.2.rst index 7d0f0e0747..8566037688 100644 --- a/docs/sphinx/source/whatsnew/v0.13.2.rst +++ b/docs/sphinx/source/whatsnew/v0.13.2.rst @@ -17,7 +17,8 @@ Deprecations Bug fixes ~~~~~~~~~ - +* Corrected argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, + in tests of :py:func:`~pvlib.ivtools.sde._fit_sandia_cocontent`. (:issue:`2613`, :pull:`2615`) Enhancements ~~~~~~~~~~~~ From 06d8abbb3f827cf451ef35de0e9b6976851c1c94 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Mon, 8 Dec 2025 10:29:48 -0700 Subject: [PATCH 3/4] move note to Testing section --- docs/sphinx/source/whatsnew/v0.13.2.rst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/sphinx/source/whatsnew/v0.13.2.rst b/docs/sphinx/source/whatsnew/v0.13.2.rst index 8566037688..2ce619eac1 100644 --- a/docs/sphinx/source/whatsnew/v0.13.2.rst +++ b/docs/sphinx/source/whatsnew/v0.13.2.rst @@ -17,8 +17,6 @@ Deprecations Bug fixes ~~~~~~~~~ -* Corrected argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, - in tests of :py:func:`~pvlib.ivtools.sde._fit_sandia_cocontent`. (:issue:`2613`, :pull:`2615`) Enhancements ~~~~~~~~~~~~ @@ -57,6 +55,8 @@ Testing * Add Python 3.14 to test suite. (:pull:`2590`) * Update pytest configuration in ``pyproject.toml`` to work with pytest 9.0. (:pull:`2596`) +* Corrected argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, + in tests of :py:func:`~pvlib.ivtools.sde._fit_sandia_cocontent`. (:issue:`2613`, :pull:`2615`) Benchmarking From 6642d620ac46360f05a59a646d684666d5e947b0 Mon Sep 17 00:00:00 2001 From: Cliff Hansen Date: Mon, 8 Dec 2025 11:08:47 -0700 Subject: [PATCH 4/4] Update docs/sphinx/source/whatsnew/v0.13.2.rst Co-authored-by: Echedey Luis <80125792+echedey-ls@users.noreply.github.com> --- docs/sphinx/source/whatsnew/v0.13.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.13.2.rst b/docs/sphinx/source/whatsnew/v0.13.2.rst index 2ce619eac1..6bc36560f8 100644 --- a/docs/sphinx/source/whatsnew/v0.13.2.rst +++ b/docs/sphinx/source/whatsnew/v0.13.2.rst @@ -55,7 +55,7 @@ Testing * Add Python 3.14 to test suite. (:pull:`2590`) * Update pytest configuration in ``pyproject.toml`` to work with pytest 9.0. (:pull:`2596`) -* Corrected argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, +* Correct argument and value order in :py:func:`~pvlib.tests.ivtools.test_sde`, in tests of :py:func:`~pvlib.ivtools.sde._fit_sandia_cocontent`. (:issue:`2613`, :pull:`2615`)