Skip to content

Use k and cap_adjustment from Array.module_parameters in PVSystem.pvwatts_dc#2715

Open
fuma900 wants to merge 7 commits intopvlib:mainfrom
fuma900:fix-2714
Open

Use k and cap_adjustment from Array.module_parameters in PVSystem.pvwatts_dc#2715
fuma900 wants to merge 7 commits intopvlib:mainfrom
fuma900:fix-2714

Conversation

@fuma900
Copy link

@fuma900 fuma900 commented Mar 11, 2026

  • Closes PVSystem.pvwatts_dc ignores k and cap_adjustment in module_parameters #2714
  • I am familiar with the contributing guidelines
  • I attest that all AI-generated material has been vetted for accuracy and is in compliance with the pvlib license
  • Tests added
  • Updates entries in docs/sphinx/source/reference for API changes.
  • Adds description and name entries in the appropriate "what's new" file in docs/sphinx/source/whatsnew for all changes. Includes link to the GitHub Issue with :issue:`num` or this Pull Request with :pull:`num`. Includes contributor name and/or GitHub username (link with :ghuser:`user`).
  • New code is fully documented. Includes numpydoc compliant docstrings, examples, and comments where necessary.
  • Pull request is nearly complete and ready for detailed review.
  • Maintainer: Appropriate GitHub Labels (including remote-data) and Milestone are assigned to the Pull Request and linked Issue.

@github-actions
Copy link

Hey @fuma900! 🎉

Thanks for opening your first pull request! We appreciate your
contribution. Please ensure you have reviewed and understood the
contributing guidelines.

If AI is used for any portion of this PR, you must vet the content
for technical accuracy.

@fuma900
Copy link
Author

fuma900 commented Mar 11, 2026

Since temp_ref wasn't documented and given the small footprint of the changes I haven't added any further documentation and/or updated the docstring. I think it might be useful to mention which keys of module_parameters are used though.

Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
@RDaxini RDaxini modified the milestone: v0.15.1 Mar 11, 2026
Copy link
Member

@RDaxini RDaxini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @fuma900
I labeled the issue as a bug fix but now, thinking about it, was this ever working in a previous version?

~~~~~~~~~~~~

* Use ``k`` and ``cap_adjustment`` from :py:func:`pvlib.pvsystem.Array.module_parameters` in :py:func:`pvlib.pvsystem.PVSystem.pvwatts_dc`
(:issue:`2714`, :pull:`2715`)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
(:issue:`2714`, :pull:`2715`)
(:issue:`2714`, :pull:`2715`)

You can add a line here to reduce the diff, which is what we would normally do. Not essential though

@cwhanse
Copy link
Member

cwhanse commented Mar 11, 2026

@RDaxini enhancement. This PR adds capability to the PVSystem method, which wasn't present before. It wasn't working but it wasn't claimed to be working, so not a bug in my mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PVSystem.pvwatts_dc ignores k and cap_adjustment in module_parameters

3 participants