Use k and cap_adjustment from Array.module_parameters in PVSystem.pvwatts_dc#2715
Use k and cap_adjustment from Array.module_parameters in PVSystem.pvwatts_dc#2715fuma900 wants to merge 7 commits intopvlib:mainfrom
k and cap_adjustment from Array.module_parameters in PVSystem.pvwatts_dc#2715Conversation
…cap_adjustment' parameters
…ts_system_kwargs fixture
Hey @fuma900! 🎉Thanks for opening your first pull request! We appreciate your If AI is used for any portion of this PR, you must vet the content |
|
Since |
Co-authored-by: Cliff Hansen <cwhanse@sandia.gov>
| ~~~~~~~~~~~~ | ||
|
|
||
| * Use ``k`` and ``cap_adjustment`` from :py:func:`pvlib.pvsystem.Array.module_parameters` in :py:func:`pvlib.pvsystem.PVSystem.pvwatts_dc` | ||
| (:issue:`2714`, :pull:`2715`) |
There was a problem hiding this comment.
| (:issue:`2714`, :pull:`2715`) | |
| (:issue:`2714`, :pull:`2715`) | |
You can add a line here to reduce the diff, which is what we would normally do. Not essential though
|
@RDaxini enhancement. This PR adds capability to the PVSystem method, which wasn't present before. It wasn't working but it wasn't claimed to be working, so not a bug in my mind. |
PVSystem.pvwatts_dcignoreskandcap_adjustmentinmodule_parameters#2714docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.