New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stable Release #337

Closed
HarpyWar opened this Issue Jan 31, 2018 · 4 comments

Comments

Projects
None yet
2 participants
@HarpyWar
Member

HarpyWar commented Jan 31, 2018

Reffering to the comment #181 (comment)
I suggest to keep stable code in master branch, and create develop branch on github. Ideally with multiple feature branches for each feature which then could be merged with develop. But at least first two will be already very good.
A successful branching model is described on http://nvie.com/posts/a-successful-git-branching-model/

@RElesgoe actually we do not have a stable release now. Your current release is unstable and contains bugs. Instead of that I always suggest users to download automated nightly binaries from https://pvpgn.pro.
But many users still download it from Releases section on github and ask about the fixed bugs. For example this https://forums.pvpgn.pro/viewtopic.php?pid=9698#p9698

@RElesgoe

This comment has been minimized.

Member

RElesgoe commented Feb 4, 2018

@HarpyWar I would consider the nightly binaries unstable since they have the latest changes that aren't tested. We should still use the Releases, but decide which commit is stable enough to build on and release. I haven't had the time to regularly distribute binaries though.

@HarpyWar

This comment has been minimized.

Member

HarpyWar commented Feb 5, 2018

Therefore nightly binaries should be created from develop branch, and stable binaries - from master.
It's easier to start these branches from the next "stable" release.

@RElesgoe

This comment has been minimized.

Member

RElesgoe commented Feb 10, 2018

HarpyWar added a commit that referenced this issue Feb 11, 2018

@HarpyWar

This comment has been minimized.

Member

HarpyWar commented Mar 28, 2018

All commits from a branch are automatically added in related pull request like here #340
One of a reason why it's better to add long term features into a different branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment