Permalink
Commits on Apr 27, 2016
  1. Merge remote-tracking branch 'refs/remotes/WordPress/master'

    Paul Wendelboe committed Apr 27, 2016
Commits on Apr 26, 2016
  1. Users: Remove the “Name” column of the Users table from appearing sor…

    …table.
    
    The “Name” column of the Users WP List Table is not sortable because this column displays a concatenation of two optional values, `first_name` and `last_name`. Even if WP_User_Query supported ordering queries in this manner, the resulting sequence would be chaotic.
    
    Fixes #28064.
    
    Props jesin, and rachelbaker.
    Built from https://develop.svn.wordpress.org/trunk@37314
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37280 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    rachelbaker committed Apr 26, 2016
  2. Post Thumbnails: Fix logic bug and tests from [37308] where post-thum…

    …bnails support wasn’t added if there were no previous post_types with support already.
    
    See #22080
    Built from https://develop.svn.wordpress.org/trunk@37313
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37279 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    rachelbaker committed Apr 26, 2016
  3. Post Thumbnails: When using `add_theme_support( ‘post-thumbnails’, ar…

    …ray( $post_types) )` merge the supported post_types.
    
    Allow the adding of post-thumbnail support for one or more post_types without unsetting any previously added post_types. This matches the behavior of other uses of `add_theme_support()` and the expectations of a function with a prefix of “add”.
    To unset post-thumbnail support use `remove_theme_support()` instead.
    
    Fixes #22080
    
    Props alexkingorg, jmichaelward, and flixos90.
    Built from https://develop.svn.wordpress.org/trunk@37308
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37274 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    rachelbaker committed Apr 26, 2016
Commits on Apr 23, 2016
  1. Build/Test Tools: Reset the PHPMailer mock in `Tests_Mail::tearDown()`.

    Props welcher.
    Fixes #36609.
    Built from https://develop.svn.wordpress.org/trunk@37307
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37273 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 23, 2016
Commits on Apr 22, 2016
  1. Comments: add a `$comment` parameter to `get_comment_author_url_link()`.

    Add unit tests (none exist).
    
    Props flixos90, wonderboymusic.
    Fixes #36573.
    
    Built from https://develop.svn.wordpress.org/trunk@37305
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37271 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    staylor committed Apr 22, 2016
  2. Comments: Add unordered list styling to Comments List Table rows and …

    …Moderate Comment screen.
    
    Fixes #36160
    
    Props juanfra.
    Built from https://develop.svn.wordpress.org/trunk@37304
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37270 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    rachelbaker committed Apr 22, 2016
  3. Comments: Keep comments safe in the Edit Post screen.

    Warns users that have added a new Comment or began editing an existing without saving their changes, before they press the “update” button which would wipe out their comment changes.
    
    Fixes #32818.
    
    Props polevaultweb.
    Built from https://develop.svn.wordpress.org/trunk@37303
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37269 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    rachelbaker committed Apr 22, 2016
  4. Dashboard: toggle the "View" link for comments when Approving / Unapp…

    …roving from the Dashboard widget.
    
    Fixes #35518.
    
    Built from https://develop.svn.wordpress.org/trunk@37302
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37268 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    staylor committed Apr 22, 2016
  5. TinyMCE: prevent showing the placeholder URL when adding a link and c…

    …licking more than once on the Insert Link button.
    
    Props iseulde.
    Fixes #36637 for trunk.
    Built from https://develop.svn.wordpress.org/trunk@37301
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37267 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    Andrew Ozz committed Apr 22, 2016
  6. Tests: Account for flexible IDs in main network deletion test

    After [37299], the network IDs encountered by this test may be larger than "100".
    
    This adjusts the test to respond accordingly until we have a better way to delete networks.
    
    See #36566.
    
    Built from https://develop.svn.wordpress.org/trunk@37300
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37266 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    jeremyfelt committed Apr 22, 2016
  7. Tests: Use the same incrementor for all fields belonging to a given t…

    …ext fixture.
    
    [35244] changed the way that `WP_UnitTest_Generator_Sequence()` created an
    incrementor for object fields (like 'post_name' and 'user_email'), by making
    incrementor static across the entire run of the test suite. While this helped
    to enforce uniqueness across the tests, it has the side effect of bumping the
    incrementor between fields on the same object (so that, eg, the same post might
    have `post_name` "post-12" but `post_title` "Post 13". By switching to a
    technique that uses the same incrementor for each field belonging to a given
    fixture, we conform better to the expectations of developers using
    `WP_UnitTest_Factory`.
    
    Fixes #35199.
    Built from https://develop.svn.wordpress.org/trunk@37299
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37265 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    boonebgorges committed Apr 22, 2016
  8. Smilies: Move `convert_smilies` to happen later in the `the_content` …

    …filter.
    
    In particular, we want it to occur after shortcode handling. The smiley conversion routine doesn't have any concept of shortcode structure, so may inadvertantly replace a smiley with HTML inside a shortcode attribute, which will cause the shortcode to not be parsed correctly.
    
    Props Unyson for the initial suggested fix.
    
    Fixes #36306. 
    
    
    Built from https://develop.svn.wordpress.org/trunk@37298
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37264 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    pento committed Apr 22, 2016
  9. Text Changes: Consistently refer to https://wordpress.org/plugins/ and

    …https://wordpress.org/themes/ as WordPress Plugin Directory and WordPress Theme Directory, respectively.
    
    Props mpol.
    Fixes #35938.
    Built from https://develop.svn.wordpress.org/trunk@37297
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37263 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 22, 2016
  10. Emoji: The `:roll:` smiley is now an emoji.

    Unicode 8 added `U+1F644`, "Face with Rolling Eyes", which matches our `:roll:` smiley. Continuing our ever present quest to rid the world of legacy smilies, we now translate that smiley into its emoji form.
    
    Sadly, `:mrgreen:` remains sorely under-represented in the Unicode standard, I'm inclined to think that we should buy a voting membership of the Unicode Consortium, in order to rectify that situation. (Personally, I'm hoping for a green skin tone modifier.)
    
    Fixes #36365.
     
    
    
    Built from https://develop.svn.wordpress.org/trunk@37296
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37262 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    pento committed Apr 22, 2016
  11. Database: Suppress connection error messages when `WP_DEBUG` isn't en…

    …abled.
    
    This is a partial revert of [35860], which has been causing un-catchable warnings to be generated on some server configurations.
    
    Fixes #36629 for trunk.
    See #21870.
    
    
    Built from https://develop.svn.wordpress.org/trunk@37292
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37258 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    pento committed Apr 22, 2016
Commits on Apr 21, 2016
  1. Media: Remove an extra quote when sending a link of a media file to t…

    …he editor.
    
    Introduced in [37035].
    
    Props joemcgill, swissspidy, boonebgorges.
    Fixes #36578.
    Built from https://develop.svn.wordpress.org/trunk@37288
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37254 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    ocean90 committed Apr 21, 2016
  2. Themes: Update list of WordPress theme features.

    * Remove color tags.
    * Layout: Add Grid Layout, remove Fixed Layout, Fluid Layout, and Responsive Layout.
    * Features: Add Footer Widgets, remove Blavatar.
    * Subject: Add Blog, E-Commerce, Education, Entertainment, Food & Drink, Holiday, News, Photography and Portfolio, remove Photoblogging and Seasonal.
    
    Props grapplerulrich, davewarfel.
    Fixes #33407.
    Built from https://develop.svn.wordpress.org/trunk@37287
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37253 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    ocean90 committed Apr 21, 2016
  3. Media: Don't cache the results of `wp_mkdir_p()` in a persistent cache.

    To improve the performance of `wp_upload_dir()` the result of `wp_mkdir_p()` was stored in a persistent cache, introduced in [36565]. But this becomes an issue when WordPress is scaled horizontally. You may end up caching a value for a server where the directory doesn't exist which will prevent further uploads on other servers because of the persistent cache.
    The fix is to use a non-persistent cache.
    
    Props azaozz, ocean90.
    See #34359.
    Fixes #36621.
    Built from https://develop.svn.wordpress.org/trunk@37285
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37251 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    ocean90 committed Apr 21, 2016
  4. Customize/Formatting: Move `sanitize_hex_color()`, `sanitize_hex_colo…

    …r_no_hash()`, and `maybe_hash_hex_color()` from `class-wp-customize-manager.php` into `formatting.php`.
    
    Adds missing braces.
    
    See #33413.
    Props downstairsdev, tollmanz.
    Fixes #27583.
    
    Built from https://develop.svn.wordpress.org/trunk@37283
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37249 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    westonruter committed Apr 21, 2016
  5. Feeds: Revert [36230] which removed the `rss-http` feed content type.…

    … Removing this means that any feeds which are using this feed content type are now being served as `application/octet-stream` instead of `text/xml`.
    
    See #36620
    
    Built from https://develop.svn.wordpress.org/trunk@37282
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37248 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    johnbillion committed Apr 21, 2016
  6. Docs: Move the clarification of `is_tax()` and `WP_Query::is_tax()` r…

    …eturn value added in [37235] to `@return` description.
    
    Props DrewAPicture.
    Fixes #36331.
    Built from https://develop.svn.wordpress.org/trunk@37281
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37247 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 21, 2016
  7. Tests: More explicit fixture content when testing `s=0` query string.

    After [36647], the unit test generator sequence can put a 0 into the
    'post_excerpt' field of a post fixture, causing false positives.
    
    See [36520] for a parallel fix involving 'post_content'.
    
    Fixes #36622.
    Built from https://develop.svn.wordpress.org/trunk@37280
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37246 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    boonebgorges committed Apr 21, 2016
  8. Administration: Introduce `admin_print_footer_scripts-$hook_suffix"`,…

    … a dynamic version of the `admin_print_footer_scripts` hook.
    
    This is now more consistent with the generic `admin_print_scripts` and the dynamic `admin_print_scripts-$hook_suffix` hooks fired in `wp-admin/admin-header.php`.
    
    Props tfrommen.
    Fixes #34334.
    Built from https://develop.svn.wordpress.org/trunk@37279
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37245 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 21, 2016
  9. Docs: Reflect the new `'user'` option for `wp_new_user_notification()…

    …`'s `$notify` parameter added in [37276] in `wp_send_new_user_notifications()` docs as well.
    
    Props ocean90.
    Fixes #36009.
    Built from https://develop.svn.wordpress.org/trunk@37278
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37244 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 21, 2016
  10. Users: Add a unit test for [37276].

    See #36009.
    Built from https://develop.svn.wordpress.org/trunk@37277
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37243 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 21, 2016
  11. Users: In `wp_new_user_notification()`, sdd `'user'` option for the `…

    …$notify` parameter, which allows for sending notification only to the user created.
    
    Props akibjorklund.
    Fixes #36009.
    Built from https://develop.svn.wordpress.org/trunk@37276
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37242 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    SergeyBiryukov committed Apr 21, 2016
  12. Rewrite Rules: After [36953], correctly replace existing rules on IIS…

    … when updating them.
    
    Props WiZZarD_.
    Fixes #36506 for trunk.
    Built from https://develop.svn.wordpress.org/trunk@37273
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37239 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    swissspidy committed Apr 21, 2016
  13. Upgrader: Clear plugin/theme caches directly after a plugin/theme has…

    … been updated.
    
    `wp_update_plugins()` and `wp_update_themes()` are both hooked into `upgrader_process_complete` with priority 10. But at this stage the caches in `get_plugins()`, `search_theme_directories()`, and `wp_get_themes()` aren't refreshed yet so both functions couldn't fetch any translations for the new plugin/theme.
    To reset the caches, `wp_clean_themes_cache()` and `wp_clean_plugins_cache()` are now hooked into `upgrader_process_complete` with priority 9.
    
    This is a follow-up to [34751].
    
    See #34029.
    Fixes #36383.
    Built from https://develop.svn.wordpress.org/trunk@37272
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37238 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    ocean90 committed Apr 21, 2016
  14. Tests: Pre-declare the `$year_url` property before initialization in …

    …`Tests_Get_Archives::setUp()`.
    
    Props pbearne.
    Fixes #36611.
    
    Built from https://develop.svn.wordpress.org/trunk@37271
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37237 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    DrewAPicture committed Apr 21, 2016
  15. Docs: Add missing return descriptions for `WP_Filesystem_SSH2::chown(…

    …)` and `WP_Filesystem_SSH2::run_command()`.
    
    Fixes #30989.
    
    Built from https://develop.svn.wordpress.org/trunk@37270
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37236 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    DrewAPicture committed Apr 21, 2016
Commits on Apr 20, 2016
  1. Tests: Exclude `ms-files` test group from default PHPUnit config

    Multisite specific tests run as normal with `phpunit.xml.dist` and multisite constants defined. The `ms-files` group causes pollution when mixed with the rest of the tests, so it should be excluded here too.
    
    See #36566.
    
    Built from https://develop.svn.wordpress.org/trunk@37269
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37235 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    jeremyfelt committed Apr 20, 2016
  2. Don't announce PR builds in Slack

    People may submit a PR to our travis build repo, we shouldn't notify slack when that happens.
    See https://docs.travis-ci.com/user/notifications/#Slack-notifications
    
    Fixes #36607
    
    
    Built from https://develop.svn.wordpress.org/trunk@37268
    
    
    git-svn-id: http://core.svn.wordpress.org/trunk@37234 1a063a9b-81f0-0310-95a4-ce76da25c4cd
    aaronjorbin committed Apr 20, 2016