New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate entry: com/github/pwittchen/reactivenetwork/library/BuildConfig.class #195

Closed
yshrsmz opened this Issue Jul 26, 2017 · 3 comments

Comments

2 participants
@yshrsmz

yshrsmz commented Jul 26, 2017

I encountered this error while migrating my app to RxJava2.
I imported both ReactiveNetwork & ReactiveNetwork2(just because I was in migration process), and got this.

It seems like you forgot to update package name in AndroidManifest.xml?

@pwittchen

This comment has been minimized.

Show comment
Hide comment
@pwittchen

pwittchen Jul 26, 2017

Owner

Hi,

In the RxJava2.x version I've changed package from com.github.pwittchen.library to com.github.pwittchen.library.rx2 to distinguish classes from different artifacts. I think you shouldn't keep both library versions in the application at the same time because it may cause code conflicts like yours. It's better to remove RxJava1.x version and then add RxJava2.x version, update imports and adjust the code. Migration should be really simple. Take a look at the migration commit for this library, where sample app was migrated as well: f35c869 (check MainActivity.java file).

Regards,
Piotr

Owner

pwittchen commented Jul 26, 2017

Hi,

In the RxJava2.x version I've changed package from com.github.pwittchen.library to com.github.pwittchen.library.rx2 to distinguish classes from different artifacts. I think you shouldn't keep both library versions in the application at the same time because it may cause code conflicts like yours. It's better to remove RxJava1.x version and then add RxJava2.x version, update imports and adjust the code. Migration should be really simple. Take a look at the migration commit for this library, where sample app was migrated as well: f35c869 (check MainActivity.java file).

Regards,
Piotr

@yshrsmz

This comment has been minimized.

Show comment
Hide comment
@yshrsmz

yshrsmz Jul 26, 2017

Thanks for your quick response.

Yes I'm going to use v2 and remove v1.

I just wanted to report that this line should be updated as well.
https://github.com/pwittchen/ReactiveNetwork/blob/RxJava2.x/library/src/main/AndroidManifest.xml#L2

yshrsmz commented Jul 26, 2017

Thanks for your quick response.

Yes I'm going to use v2 and remove v1.

I just wanted to report that this line should be updated as well.
https://github.com/pwittchen/ReactiveNetwork/blob/RxJava2.x/library/src/main/AndroidManifest.xml#L2

@pwittchen

This comment has been minimized.

Show comment
Hide comment
@pwittchen

pwittchen Jul 26, 2017

Owner

Ok, thanks. We'll update it.

Owner

pwittchen commented Jul 26, 2017

Ok, thanks. We'll update it.

@pwittchen pwittchen added the bug label Jul 26, 2017

@pwittchen pwittchen closed this in ffc7f52 Jul 26, 2017

@pwittchen pwittchen referenced this issue Aug 4, 2017

Closed

Release 0.11.0 #194

16 of 16 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment