New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration to run NullAway #226

Merged
merged 1 commit into from Sep 13, 2017

Conversation

2 participants
@msridhar
Contributor

msridhar commented Sep 13, 2017

I figured out one way to add NullAway to the project (may not be the absolute cleanest). We will update our READMEs to be more clear about this type of scenario (see uber/NullAway#10). Note that you'll have to fix the NullAway errors before merging this back, which may require adding some number of code annotations.

@pwittchen

This comment has been minimized.

Show comment
Hide comment
@pwittchen

pwittchen Sep 13, 2017

Owner

Thanks for your PR! Looks interesting. I'll review that & update the library. If everything will be fine, we can merge this update because I like the general idea of NullAway.

Owner

pwittchen commented Sep 13, 2017

Thanks for your PR! Looks interesting. I'll review that & update the library. If everything will be fine, we can merge this update because I like the general idea of NullAway.

@pwittchen pwittchen merged commit 4a48224 into pwittchen:RxJava2.x Sep 13, 2017

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
@pwittchen

This comment has been minimized.

Show comment
Hide comment
@pwittchen

pwittchen Sep 13, 2017

Owner

Ok, I've updated the library and merged this PR. This tool found a few bugs or issues, which I could fix, so it's a nice improvement :).

Owner

pwittchen commented Sep 13, 2017

Ok, I've updated the library and merged this PR. This tool found a few bugs or issues, which I could fix, so it's a nice improvement :).

@msridhar

This comment has been minimized.

Show comment
Hide comment
@msridhar

msridhar Sep 13, 2017

Contributor

Great to hear it!

Contributor

msridhar commented Sep 13, 2017

Great to hear it!

pwittchen added a commit that referenced this pull request Jun 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment