Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate support lib dependencies to AndroidX. #332

Merged
merged 1 commit into from May 11, 2019

Conversation

Projects
None yet
3 participants
@ychescale9
Copy link
Contributor

commented May 11, 2019

Closes #331

PR migrates support lib to AndroidX:

com.android.support:support-annotations:28.0.0 -> androidx.annotation:annotation:1.0.2
com.android.support:appcompat-v7:28.0.0 -> androidx.appcompat:appcompat:1.0.2

Note that the library itself only depends on the annotation library, appcompat is used by sample app.

The following have also been updated:

  • Kotlin 1.3.31
  • RxJava 2.2.8
  • RxAndroid 2.1.1
@codecov-io

This comment has been minimized.

Copy link

commented May 11, 2019

Codecov Report

Merging #332 into RxJava2.x will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           RxJava2.x     #332   +/-   ##
==========================================
  Coverage      83.17%   83.17%           
==========================================
  Files             11       11           
  Lines            434      434           
  Branches          33       33           
==========================================
  Hits             361      361           
  Misses            47       47           
  Partials          26       26
Impacted Files Coverage Δ
...n/reactivenetwork/library/rx2/ReactiveNetwork.java 83.33% <ø> (ø) ⬆️
.../strategy/MarshmallowNetworkObservingStrategy.java 100% <ø> (ø) ⬆️
...chen/reactivenetwork/library/rx2/Connectivity.java 68.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea2ece2...62d62ac. Read the comment docs.

@pwittchen

This comment has been minimized.

Copy link
Owner

commented May 11, 2019

Looks reasonable. Thanks! I'll include this change in the next release. :)

@pwittchen pwittchen merged commit cf07132 into pwittchen:RxJava2.x May 11, 2019

3 checks passed

codecov/patch Coverage not affected when comparing ea2ece2...62d62ac
Details
codecov/project 83.17% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@ychescale9 ychescale9 deleted the ychescale9:yc/androidx branch May 12, 2019

@pwittchen pwittchen referenced this pull request May 12, 2019

Closed

Release 3.0.3 #333

7 of 7 tasks complete
@pwittchen

This comment has been minimized.

Copy link
Owner

commented May 13, 2019

@ychescale9 this update is available in the latest release 3.0.3

@ychescale9

This comment has been minimized.

Copy link
Contributor Author

commented May 13, 2019

@pwittchen Thanks! That was quick:)

@pwittchen

This comment has been minimized.

Copy link
Owner

commented May 16, 2019

That's the way it should be :).

@ychescale9 Just being curious: can you tell me in what app are you using this library or can you send any link here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.