Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug: State CONNECTED sometimes is not returned when wifi is turned off while having mobile internet connection (Android 9) - fixes #330 #359

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@pwittchen
Copy link
Owner

commented Aug 6, 2019

This PR introduces the following update:

fixes #330 and #307

solving issue #330 - emitting last connectivity instead of current co…
…nnectivity in case when the connectivity type changed and previous state was CONNECTED to avoid false-positive items on the stream

@pwittchen pwittchen force-pushed the issue-330 branch from 691ab57 to 7aab191 Aug 6, 2019

@codecov-io

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #359 into RxJava2.x will decrease coverage by 0.18%.
The diff coverage is 76.92%.

Impacted file tree graph

@@              Coverage Diff              @@
##           RxJava2.x     #359      +/-   ##
=============================================
- Coverage      83.17%   82.99%   -0.19%     
=============================================
  Files             11       11              
  Lines            434      447      +13     
  Branches          33       37       +4     
=============================================
+ Hits             361      371      +10     
- Misses            47       50       +3     
  Partials          26       26
Impacted Files Coverage Δ
...chen/reactivenetwork/library/rx2/Connectivity.java 68.14% <ø> (ø) ⬆️
.../strategy/MarshmallowNetworkObservingStrategy.java 95.16% <76.92%> (-4.84%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d3de35...7aab191. Read the comment docs.

@pwittchen pwittchen merged commit fd625ee into RxJava2.x Aug 6, 2019

4 checks passed

codecov/patch 76.92% of diff hit (within 10% threshold of 80%)
Details
codecov/project 82.99% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pwittchen pwittchen deleted the issue-330 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.