Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replacing default protocol HTTP with HTTPS in WalledGardenInternetObservingStrategy #361

Merged
merged 1 commit into from Aug 6, 2019

Conversation

@pwittchen
Copy link
Owner

commented Aug 6, 2019

fixes #323 and #299

This PR introduces the following update:

[briefly describe your update, e.g. closes specified issue, fixes a bug, adds new unit test, etc.]

@codecov-io

This comment has been minimized.

Copy link

commented Aug 6, 2019

Codecov Report

Merging #361 into RxJava2.x will increase coverage by 0.22%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##           RxJava2.x     #361      +/-   ##
=============================================
+ Coverage      82.99%   83.22%   +0.22%     
=============================================
  Files             11       11              
  Lines            447      447              
  Branches          37       37              
=============================================
+ Hits             371      372       +1     
- Misses            50       51       +1     
+ Partials          26       24       -2
Impacted Files Coverage Δ
...trategy/WalledGardenInternetObservingStrategy.java 97.5% <100%> (+2.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd625ee...9ce9c89. Read the comment docs.

@pwittchen pwittchen merged commit 02f0575 into RxJava2.x Aug 6, 2019

4 checks passed

codecov/patch 100% of diff hit (target 80%)
Details
codecov/project 83.22% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@pwittchen pwittchen deleted the issue-323 branch Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.