Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd "lyrics" as a command #38
Conversation
pwittchen
requested changes
Jan 30, 2019
README.md Outdated
spotifycli/spotifycli.py Outdated
spotifycli/spotifycli.py Outdated
spotifycli/spotifycli.py Outdated
spotifycli/spotifycli.py Outdated
This comment has been minimized.
This comment has been minimized.
Hi @Arsukeey. Thanks for your PR and contribution. It's nice idea and we can add such functionality. Nevertheless, I don't like a few things in the code. I've added my suggestions in the code review. Moreover, please fix code formatting (you can find details in the Regards, |
This comment has been minimized.
This comment has been minimized.
Thank you for the heads-up, I was changing some variable names for testing and I forgot to remove/rename that. |
This comment has been minimized.
This comment has been minimized.
Thanks for the update. There's still wrong formatting, not updated |
This comment has been minimized.
This comment has been minimized.
Thanks for the website! |
This comment has been minimized.
This comment has been minimized.
Thanks, Can you squash your 8 commits into one? I prefer to have more organized history on git (1 commit / PR). It can be done by rebasing and squashing the commits. |
Arsukeey
force-pushed the
Arsukeey:master
branch
2 times, most recently
from
572d17f
to
af325a0
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
Done! :D |
pwittchen
requested changes
Jan 30, 2019
spotifycli/spotifycli.py Outdated
spotifycli/spotifycli.py Outdated
spotifycli/spotifycli.py Outdated
This comment has been minimized.
This comment has been minimized.
Thanks! We're almost there. I have only last small issues with the code. Please, have a look at them. Of course, I'll test it before merge ;-). |
Arsukeey
force-pushed the
Arsukeey:master
branch
2 times, most recently
from
5f95650
to
1143fef
Jan 30, 2019
This comment has been minimized.
This comment has been minimized.
Fixed the issues. |
Arsukeey
force-pushed the
Arsukeey:master
branch
from
51e33fb
to
7eb88c6
Feb 1, 2019
This comment has been minimized.
This comment has been minimized.
When I execute:
I constantly get:
but I've already installed lyricwikia with pip :(. Maybe something is wrong with my configuration or it work differently in a scripts like that, but I don't know how to fix it. |
This comment has been minimized.
This comment has been minimized.
Have you tried to import it in the terminal? Try to |
pwittchen
approved these changes
Feb 2, 2019
pwittchen
merged commit 7eb88c6
into
pwittchen:master
Feb 2, 2019
1 check passed
This comment has been minimized.
This comment has been minimized.
Ok, after reinstalling package, it worked :-D. |
Arsukeey commentedJan 30, 2019
I've added the feature to show the lyrics for the song that is currently playing.
However, it adds a dependency: lyricwikia.
Sorry if you don't want more dependencies to your project, but I thought it would be cool to add this feature, because I downloaded your program for it, and I was surprised when I didn't find it.