let consumers specify custom HTTP headers #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 20, 2015
|
Incidentally, I based this on the similar feature in https://www.npmjs.com/package/github. That module also lets you set custom headers per-request, which I can add if you'd like, although it isn't necessary for my particular use case. |
|
+1 |
|
Also, a default user-agent value would allow us to whitelist the library. |
|
@pwmckenna can you merge this pull-request? this issue hurts me everyday |
|
sorry for the delay. this looks great. @rkh any preference on user-agent string to use? |
pwmckenna
pushed a commit
that referenced
this pull request
Dec 27, 2015
let consumers specify custom HTTP headers
|
just published to npm as version 2.1.0. thanks again everyone! also, my delay time on this things has gone way up, so if anyone is interested in helping maintain I'd appreciate the help. Happy to give walkthroughs etc if need be. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases it's helpful for API consumers to be able to set custom HTTP headers, particularly User-Agent, because the Travis API servers will whitelist certain values of that header (in response to problems like https://www.traviscistatus.com/incidents/bntk781kb8y8). This branch adds a headers option that accepts custom headers to set on requests.
I'm not sure how to unit test this, as I don't see other unit tests that are checking the values of request headers. But I've confirmed that it enables me to fix a problem with accessing a Travis API endpoint by specifying a whitelisted User-Agent header.