Repository navigation
Accept args given in the format string of printf-like functions - #1038
Closed
generalmimon wants to merge 4 commits into
Closed
generalmimon wants to merge 4 commits into
generalmimon wants to merge 4 commits into
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #1038 +/- ##
==========================================
- Coverage 49.82% 49.68% -0.14%
==========================================
Files 159 159
Lines 18627 18681 +54
Branches 1512 1530 +18
==========================================
+ Hits 9280 9281 +1
- Misses 9047 9100 +53
Partials 300 300
Continue to review full report at Codecov.
|
See pwndbg#939 It doesn't really adjust the value format (as I thought it would when I provide the argument type, but it turns out it's not interpreted anywhere), so e.g. for floats you won't get anything nice as 1.5 but still some unreadable 0x..., but at least it's a start of reading `printf` arguments.
As the code comment explains, the table is not currently used, but it may be useful in the future.
generalmimon
force-pushed
the
accept-printf-args
branch
from
July 16, 2022 17:37
4e565ef to
efb4cc1
Compare
generalmimon
commented
Jul 16, 2022
Member
|
I'll close this for now but keep a reference to it in #939 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cc @disconnect3d (made on the EuroPython 2022 sprint)
See #939
It doesn't really adjust the value format (as I thought it would when I provide the argument type, but it turns out it's not interpreted anywhere), so e.g. for floats you won't get anything nice as 1.5 but still some unreadable 0x..., but at least it's a start of reading
printfarguments.