Skip to content

Fix parsing complex symbols (#1050) #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ntsleep
Copy link
Contributor

@ntsleep ntsleep commented Aug 11, 2022

A quick attempt to fix #1050. It requires more testing with different commands.

@ntsleep ntsleep marked this pull request as draft August 11, 2022 18:40
@disconnect3d
Copy link
Member

Yeah... so as we can see in the tests failing, while this fixes the issue with parsing complex symbols, it unfortunately breaks the case when we just want to pass in a space in quotes as an argument.

image

FWIW I have asked on GDB irc channel about this behavior vs the expected GDB behavior on parsing commands (because oh well, the print or examine commands in GDB parses those complex symbols properly when quotations are there) and I got no reply yet. I will try to ping the corresping people there.

Btw @ntsleep we should add a testcase for this behavior first and work on a solution that does not break other tests.

Though, I am not sure what that solution would be yet... I think we should maybe try to debug the GDB's print/examine commands and the way they parse input and see if that would give us a hint.

@disconnect3d
Copy link
Member

This seems invalid/not an issue. See #1050.

@ntsleep ntsleep deleted the 1050-parse-complex-symbols branch September 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Commands that take address can't parse complex symbols
2 participants