Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Capstone to 4.0.1 #591

Merged
merged 1 commit into from Jan 15, 2019

Conversation

Projects
None yet
2 participants
@disconnect3d
Copy link
Member

commented Jan 15, 2019

As it is there! https://pypi.org/project/capstone/#history

It has a minor bug which hits us when we do version command, but it isn't that big deal (see aquynh/capstone#1315 (comment)).

@disconnect3d disconnect3d merged commit 068bcff into pwndbg:dev Jan 15, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@disconnect3d disconnect3d deleted the disconnect3d:bump-capstone branch Jan 15, 2019

@zachriggle

This comment has been minimized.

Copy link
Member

commented Jan 15, 2019

Do we have any actual dependencies on Capstone 4.x at all?

Edit: I am assuming that we do, since we were reliant on next (which was the unreleased 4.x).

Since Capstone has broken our old install script, we may need to cut a new stable release (or at least cherry-pick the requirements changes).

@disconnect3d

This comment has been minimized.

Copy link
Member Author

commented Jan 15, 2019

Capstone 4.x adds some new features and fixes some bugs (e.g. adds endbr32 and endbr64 instructions for x86/x64) so it's a nice to have (otherwise, the context disasm crashes when one of those instructions appear).

Re: release - yeah, need to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.