Size & position not maintained on scaled displays

[ronys]

On systems with high resolution displays and Scale > 100%, the last size & position of the main window is incorrectly restored.

[ronys]

Fixed in commit 1588ace

[gillius]

This might have broken things for me, when upgrading from 3.64.1 to 3.65.1 the display appears as "blurry" upscaled again. This is something that has changed multiple times over the course of pwsafe (maybe last time it worked is after #966). I'm using 64-bit version of pwsafe and I confirmed in compatibility settings there is nothing checked in high DPI compatibility.

The initial dialog where you select a database is properly scaled with full resolution. Title bars on all windows are also fine. But once the application starts, the icons, menu bar, password tree, and edit entry are all upscaled and blurry, but the same "physical" size as the old 3.64.1.

I think it's awesome TOTP support came to 3.65. I have a separate TOTP app and maybe someday I will migrate the data over but for now as I'm not using that I downgraded back to 3.64.1 and it works. I did not try 3.65.0 but will if you feel it will help provide some context.

[gillius]

Actually, I just tested 3.65.0 64-bit version it does not work either, all the text is blurry. So something not listed in the release notes https://pwsafe.org/news.shtml probably affected something in 3.65.0 for me. I can file a separate issue if it makes sense.

Thanks for all of your efforts on maintaining this tool! For me, I'm OK with 3.64.1 for now this is not a hot item.

[ronys]

@gillius - what display resolution do you have, and what scale are you using?

A screenshot (of a test database) illustrating the problem would be great. Note that you have to uncheck "Exclude from screen capture" in Manage->Options->Security to take a screenshot.

[gillius]

@ronys thank you for the reply, I can open a separate issue if needed.

My resolution is 3840x2160. The scale is set to 150%. I am on Windows 11.

Here is version 3.65.01 64-bit about screen where you can see some properly scaled and other text not.

Same version with add entry screen where you can see it's rendered at lower resolution then scaled up in size

Old pwsafe v3.64.01 where the scaling is "native" at "full resolution" (i.e. the text is rendered at 150% instead of what appears to be rendered at 100% and raster upscaled)

[ronys]

@gillius , can you try the following:
Right click on the pwsafe.exe file in C:\Program Files\Password Safe, Properties->Compatibility->Change high DPI settings.

There, you can try changing Program DPI or High DPI scaling override.
Let me know if any setting makes a difference.

[gillius]

@ronys Program DPI option did not change the behavior for me, but overriding the scaling to application or system made it rendered at full resolution. System (enhanced) made it look just a little blurry but it seemed not as bad as with no configuration. However, in these modes at least with application scaling, every time opening and closing the database it shifted in +x and +y offset and width and height of the window increased. This is with 3.65.1 so it would have included fixes for this GH issue.

I didn't see any direct docs on how to build an executable, but a bunch of docs with choosing wxwidgets or not. Is this something reasonably buildable just by installing MSVC community + cmake and running cmake build? I'm a Java dev and haven't done C++ in almost 20 years but I might be willing to try out a git bisect if it's easy enough to build, although it could be up to a week before I can get to it, but I am not in a rush since I'm not using the new TOTP feature yet. I didn't see any commits that caught my eye as a likely cause though between the two versions.

[ronys]

@gillius Yes, cmake and MSVC community are what I'm using.
There are a couple of documents that are out of date, but should get your pointed in the right direction: README.CMAKE.md and README.WINDOWS.DEVELOPERS.html (note to self: unify and update).

As to commits, the following is probably what you're looking for:
1588ace [2 months ago] [GH1092] Fix restore size & pos on Scaled displays (bump rev to 3.65.1) [ronys]

[gillius]

@ronys I finally got to build it. I think there might be something in how it is built, because the versions I build from master branch (debug x64) and tag 3.65.1 (debug and release x64) work fine. I even tried to remove my pwsafe.cfg thinking maybe that has something to do with it, but didn't change anything. Here's a side by side screenshot of installed 3.65.1 next to git checkout of tag 3.65.1 running in debug mode (since if I try to run in release mode it prevents multiple-instances):

The dialogs are also upscaled in github downloaded release file but not in locally built version:

Since my build of 3.65.1 worked I didn't try to git bisect to find out where it "broke" between 3.64.1 and 3.65.0 (the GH download for 3.65.0 and 3.65.1 both get fuzzy upscaled for me).

I had some challenges building the project, but pieced it together from the 2 docs you provided. Neither were completely accurate for me.

Install

1. Installed VS 2022 Community through winget: winget install -e --id Microsoft.VisualStudio.2022.Community
2. Installed cmake through winget: winget install -e --id Kitware.CMake
3. Launched VS 2022 IDE, skip account and open without code
4. Select Tools and Get Tools and Features
5. In Workloads, select:
   1. Desktop development with C++
6. In Individual Components search for and select:
   1. C++ CMake tools for Windows
   2. Windows 11 SDK
   3. C++ MFC for latest v143 build tools (x86 & x64)

Notes:

• If you skip CMake tools you'll get an error when running CMake that it cannot find any instance of visual studio
• If you skip Windows 11 SDK you'll get an error when running CMake "no cmake_cxx_compiler could be found"
• If you skip Desktop development with C++ or MFC, you'll be prompted to install them later when you open the generated solution

Generate Solution

I used cmake -S . -B _build to generate the build files from the pwsafe folder, but the cmake-gui instructions from the README.CMAKE.md also work in this part I think.

I noticed during cmake configure it found my existing Python 3.11.9 installation. Is that required/useful? If it is maybe someone else following this would need Python. Also I didn't need to follow the directions to get gtest mentioned in README.CMAKE.md. It looked like it might have downloaded it during cmake configure?

Double click on the generated _build/passwordsafe.sln file to open Visual Studio.

Right click pwsafe project in the solution and pick "Set as startup project". Then pick "start without debugging" (ctrl-F5) or other desired option if you want debugging, change to Release build, etc. Once it starts, it will launch Password Safe. Note, it looks like in debug mode it uses default settings and closing app doesn't end the process but leaves it in system tray. I had to remember to exit it there before restarting app.

[ronys]

@gillius - thanks for the build notes. I've incorporated them in README.WINDOWS.DEVELOPERS.md, replacing README.WINDOWS.DEVELOPERS.html.

I think the issue is fixed in your build because your building on a machine running Windows 11, whereas my main development machine is Windows 10. Very sad, mainly because this will complicate my release procedure...

[gillius]

@ronys glad my experience could be useful.

Do you think it's the build OS, or the SDK installation? Can you build using latest Win 11 SDK in Win 10? What about Github Actions to build?

These are just thoughts, since I've not done a native project in a very long time, but such an issue even from modern Windows development seems surprising to me on this point. If there is anything else I can help with on this point let me know.

[ronys]

Hi @gillius,

I've updated the SDK on my Windows 10 machine, and would appreciate it if you could test the resulting build on your platform.
You can download the build artifacts from https://sourceforge.net/projects/passwordsafe/files/PreReleases/3.66.0pre/

Thanks!