Added support for CSS page break properties + bugfixes #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lucas-C
force-pushed
the
page-break-after-before
branch
2 times, most recently
from
bf013d7
to
00fc1d9
Compare
|
If you want to review this @gmischler & @andersonhc, I'll be happy to have your feedbacks 🙂 Else I'll merge this later this week. |
Lucas-C
force-pushed
the
page-break-after-before
branch
7 times, most recently
from
9346116
to
7cc0695
Compare
Lucas-C
changed the title
Lucas-C
force-pushed
the
page-break-after-before
branch
from
7cc0695
to
c0dcf20
Compare
Lucas-C
changed the title
Lucas-C
force-pushed
the
page-break-after-before
branch
4 times, most recently
from
c18a26a
to
05f02d4
Compare
Lucas-C
changed the title
Lucas-C
force-pushed
the
page-break-after-before
branch
2 times, most recently
from
ee79ee1
to
8d09425
Compare
gmischler
reviewed
Jun 17, 2024
Lucas-C
force-pushed
the
page-break-after-before
branch
2 times, most recently
from
0efe4fb
to
e0a5ec2
Compare
|
@gmischler: would you like to take the time to review this PR more in-depths? |
Lucas-C
force-pushed
the
page-break-after-before
branch
from
e0a5ec2
to
7a3d88b
Compare
gmischler
approved these changes
Jun 18, 2024
…space to be rendered on a page
Lucas-C
force-pushed
the
page-break-after-before
branch
from
7a3d88b
to
5c02331
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also fixes a bug introduced in PR #1207 regarding
font_size_ptset in the current graphics state when using.local_context().Before merging this PR, this bug is visible on the
masterbranch in the following reference files:I did not see this regression in PR #1207 because I misread the positioning of the PDFs in the HTML page produced by
scripts/compare-changed-pdfs.py: in order to avoid this to happen again, I added an explicit legend at the top of the page, explaining what are the PDFs in the left & right columns.Finally, this PR also fixes automatic page break when an image, inserted through
.write_html()withoutheightattribute, does not have enough vertical space to be rendered on a page.Checklist:
The GitHub pipeline is OK (green), meaning that both
pylint(static code analyzer) andblack(code formatter) are happy with the changes of this PR.A unit test is covering the code added / modified by this PR
This PR is ready to be merged
In case of a new feature, docstrings have been added, with also some documentation in the
docs/folderA mention of the change is present in
CHANGELOG.mdBy submitting this pull request, I confirm that my contribution is made under the terms of the GNU LGPL 3.0 license.