Skip to content

Conversation

@willingc
Copy link
Collaborator

@willingc willingc commented Apr 1, 2024

This PR adds lychee (a Rust based link checker) to run just before the HTMLProofer. Lychee only takes about 15 sec to check all of the links. It will be a good check that htmlproofer is working as expected with the links.

@willingc willingc marked this pull request as ready for review April 2, 2024 00:15
@willingc willingc requested a review from lwasser as a code owner April 2, 2024 00:15
@lwasser
Copy link
Member

lwasser commented Apr 2, 2024

awesome! ill look at this tomorrow. if this works we can just turn off link checking in html proofer and use it only for alt tags! that could solve all of our issues if lychee doesn't get hung up on new links that aren't yet on our website!

@lwasser lwasser merged commit b18e8bf into pyOpenSci:main Apr 2, 2024
@lwasser
Copy link
Member

lwasser commented Apr 2, 2024

i'm going to pull this into another pr via a rebase. i suspect then we can use the htmproofer action to just check images or we can find another tool that does alt tags / accessibility ? thank you @willingc i'm tired of fighting with htmlproofer!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants