Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed removing non empty directory. Added create directory. #153

Merged
merged 5 commits into from Nov 5, 2014

Conversation

@max107
Copy link
Contributor

max107 commented Nov 4, 2014

No description provided.

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

Need add parent entry with a project name for comfortable create directories. Create issue in this repository?

Like this:

screen shot 2014-11-04 at 20 00 42

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

Hello,

Thank you for your contribution!

About the create directory action, I would prefer to add that action to a sub-menu called New and make that menu a public attribute so that users can add their own create action (e.g. for creating new python module or packages or anything specific).

About the parent entry, it would be better to open a new issue on the centralised issue tracker and discuss it there (it won't be trivial to add) ;)

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

@ColinDuquesnoy ping, how about merge to dev branch?

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

Don't you want to move the create directory action to a sub-menu before I merge?

Btw there is no develop branch anymore, do you mean master?

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

Ok, i move this action to submenu. About development branch - i know, but development branch need ;)

P.S. - i am need to learn English = ( difficult to communicate

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

About development branch - i know, but development branch need ;)

What? Don't worry, I'll merge it to the main development branch. Just let me know when you're done ;)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

I also speak french if that helps ;)

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

I also speak french if that helps ;)

Sorry, but no :) Ru :)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

Too bad...LOL :)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

Also don't forget to add your name to AUTHORS.rst

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

Looks good to me. May I merge?

@coveralls

This comment has been minimized.

Copy link

coveralls commented Nov 4, 2014

Coverage Status

Coverage decreased (-0.33%) when pulling acf34e7 on max107:tree into da58f33 on pyQode:master.

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

Hm... wait please :) I complete pyQode/pyQode#5 and merge. :)

@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 4, 2014

No problem...I am going to sleep soon so take your time to complete this ;)

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 4, 2014

123

321

Disabled names for file: ., .., os.sep
Disabled names for folder: .., .

ColinDuquesnoy added a commit that referenced this pull request Nov 5, 2014
Fixed removing non empty directory. Added create directory.
@ColinDuquesnoy ColinDuquesnoy merged commit a707d80 into pyQode:master Nov 5, 2014
1 check passed
1 check passed
continuous-integration/travis-ci The Travis CI build passed
Details
@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 5, 2014

Awesome! Thank you very much!

ColinDuquesnoy added a commit that referenced this pull request Nov 5, 2014
 - use path.normpath instead of replacing \
 - fix ``ignore_directories`` (must use ignore_items)
 - fix create file if path has an extension
 - use icons for actions

See #153
@ColinDuquesnoy

This comment has been minimized.

Copy link
Contributor

ColinDuquesnoy commented Nov 5, 2014

@max107 I've fixed a few things (the ignore_directories function was broken and the check you added for new files did not take extension into account).

@max107

This comment has been minimized.

Copy link
Contributor Author

max107 commented Nov 5, 2014

Thanks! Tested on osx, linux. All ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.