Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace miniconda by micromamba in CI #257

Merged
merged 8 commits into from
Jan 28, 2022
Merged

Conversation

aperezhortal
Copy link
Member

This PR takes #256 one step further using the mamba-org/provision-with-micromamba@main action to create the environment, instead of conda-incubator/setup-miniconda@v2

Although the computational time saved is minimal (a minute at the most), it simplifies a little bit the workflow specification, condensing the previous "miniconda installation" and "environment creation" task into a single one.

More information on micromamba: https://github.com/mamba-org/mamba#micromamba

@codecov
Copy link

codecov bot commented Jan 15, 2022

Codecov Report

Merging #257 (092e0e8) into master (7213c95) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   80.92%   80.92%           
=======================================
  Files         142      142           
  Lines       10759    10759           
=======================================
  Hits         8707     8707           
  Misses       2052     2052           
Flag Coverage Δ
unit_tests 80.92% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7213c95...092e0e8. Read the comment docs.

Copy link
Member

@dnerini dnerini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is real nice, I didn't know about a micromamba!

@kmuehlbauer
Copy link

@aperezhortal Nice, I was just doing the same over at h5netcdf, but using the old style downloading via snakepit (as wradlib does). And then I see this new provisioning thing popping up in your commits. That saved me quite some keyboard time. Just wanted to say thanks 😀

@dnerini
Copy link
Member

dnerini commented Jan 28, 2022

@aperezhortal you wanna merge this or is it still work in progress?

@aperezhortal aperezhortal merged commit 5f162d4 into master Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants