-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug in creation of RangeEdit using create_widget #396
Conversation
updates: - [github.com/psf/black: 22.1.0 → 22.3.0](psf/black@22.1.0...22.3.0)
Codecov Report
@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 88.61% 88.59% -0.03%
==========================================
Files 30 30
Lines 3796 3797 +1
==========================================
Hits 3364 3364
- Misses 432 433 +1
Continue to review full report at Codecov.
|
thanks @Czaki! These changes make sense / work for me. more broadly, I think the issue here stems from having these "container-based" classes that more or less implement the This change is totally fine with me as a first step... maybe in the future, I can get around to making them actually be |
it will be also nice if |
This came up before in some issue, can't find it atm, since not all widgets are necessarily value widgets, I'm not sure that's the proper annotation? |
Hm. In general I know because Container is also widget. But what input to Or you think about user registered widget? |
Yeah, thats a good question :) I can't immediately think of one. I'm open to it. I remember trying to change it one point and then realizing that changing that annotation requires a lot of other type changes elsewhere, but it might be worth it. Feel free to dig a bit deeper if you're interested |
If I should fix somehow failing test? It looks non-related. |
When run this code
it ends with error:
When fixing this error by checking if
value
isNone
orUNSET
then also happens problem with an unexpectednullable
field.The second error I fix by
pop
thenullable
from kwargs. But I'm not sure if it is the correct solution.