style: use ruff format instead of black, update pre-commit, restrict pyside6 tests #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
- Coverage 87.46% 87.30% -0.16%
==========================================
Files 46 46
Lines 3334 3333 -1
==========================================
- Hits 2916 2910 -6
- Misses 418 423 +5 ☔ View full report in Codecov by Sentry. |
tlambert03
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #230. and gets tests working again
disallows pyside6.6.2 cause it breaks throttlers: https://bugreports.qt.io/browse/PYSIDE-2627
additionally, I'm rearranging the slider tests to go last because of a segfault that has started appearing on pyside6.5+. I believe it's related to this change (or something related to it): qtproject/pyside-pyside-setup@db40e3e
(I find that signal instances are getting deleted erroneously, but I haven't narrowed it down yet. works fine on pyqt6)
napari tests are failing due to napari/napari#6718