-
-
Notifications
You must be signed in to change notification settings - Fork 754
Closed
Labels
difficulty: easyA good issue for someone new. Can be done in a few hoursA good issue for someone new. Can be done in a few hourspriority: mediumTo be resolved if time allowsTo be resolved if time allows
Description
I think the transition to using python files or json file (BPX) for parameter values has gone fairly well so we can start to deprecate some of the old methods for importing values from csv files. These are no longer recommended but still possible from the codebase. We should also update the training videos on this very soon.
- remove functionality to update from chemistry (old approach with separate files for anode/cathode/electrolyte etc)
- remove functionality to load from csv
- remove functionality to load a function from a string "[function]function_name"
- remove functionality to load data from a string "[data]data_name"
Basically, users will be responsible for passing in a python dictionary where functions are python functions. Interpolants can be created as functions like this
This is a breaking change so let's discuss before committing
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
difficulty: easyA good issue for someone new. Can be done in a few hoursA good issue for someone new. Can be done in a few hourspriority: mediumTo be resolved if time allowsTo be resolved if time allows