Theoretical energy integral is very slow

[valentinsulzer]

This for loop is killing us and should be vectorized:

PyBaMM/pybamm/models/full_battery_models/lithium_ion/electrode_soh.py

Lines 1007 to 1011 in 33d2187

	for i in range(x_vals.size):
	Vs[i] = (
	parameter_values.evaluate(param.p.prim.U(y_vals[i], T)).item()
	- parameter_values.evaluate(param.n.prim.U(x_vals[i], T)).item()
	)

[valentinsulzer]

[AbhishekChaudharii]

I tried vectorizing it but it seems that performing binary operations between NumPy arrays and <class 'pybamm.parameters.parameter_values.ParameterValues'> might not be supported.

Error : NotImplementedError: BinaryOperator not implemented for symbols of type <class 'numpy.ndarray'> and <class 'pybamm.expression_tree.scalar.Scalar'>

[valentinsulzer]

Ok I'll look into this