Skip to content

Trigger GitHub Actions on PR - #1013

Merged
valentinsulzer merged 3 commits into
pybamm-team:developfrom
dalonsoa:patch-2
May 21, 2020
Merged

Trigger GitHub Actions on PR#1013
valentinsulzer merged 3 commits into
pybamm-team:developfrom
dalonsoa:patch-2

Conversation

@dalonsoa

Copy link
Copy Markdown
Contributor

Description

Enable triggering of GitHub Actions on PR.

Fixes #1012

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@valentinsulzer valentinsulzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just need to fix changelog conflicts to merge

@valentinsulzer
valentinsulzer merged commit a45f180 into pybamm-team:develop May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests are not run on PRs from forks

2 participants