Skip to content

#1070 add length scales - #1071

Merged
rtimms merged 2 commits into
developfrom
issue-1070-effective-cc-lengthscale
Jun 23, 2020
Merged

#1070 add length scales#1071
rtimms merged 2 commits into
developfrom
issue-1070-effective-cc-lengthscale

Conversation

@rtimms

@rtimms rtimms commented Jun 23, 2020

Copy link
Copy Markdown
Contributor

Description

Add length scales to effective resistance models. Also fix effective volumetric heat capacity, which was missing the current collector contributions.

Fixes #1070

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)
  • Optimization (back-end change that speeds up the code)
  • Bug fix (non-breaking change which fixes an issue)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov

codecov Bot commented Jun 23, 2020

Copy link
Copy Markdown

Codecov Report

Merging #1071 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1071   +/-   ##
========================================
  Coverage    97.72%   97.72%           
========================================
  Files          237      237           
  Lines        12435    12437    +2     
========================================
+ Hits         12152    12154    +2     
  Misses         283      283           
Impacted Files Coverage Δ
...ollector/effective_resistance_current_collector.py 96.39% <100.00%> (+0.03%) ⬆️
pybamm/parameters/standard_parameters_lead_acid.py 100.00% <100.00%> (ø)
...bamm/parameters/standard_parameters_lithium_ion.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c7a06e...c559519. Read the comment docs.

@rtimms
rtimms merged commit 5585046 into develop Jun 23, 2020
@rtimms
rtimms deleted the issue-1070-effective-cc-lengthscale branch June 23, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

length scales for effective current collector model

2 participants