#1080 require t_eval

[rtimms]

Description

Make t_eval are required argument in sim.solve() when not using an experiment or drive cycle

Fixes #1080

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

• New feature (non-breaking change which adds functionality)
• Optimization (back-end change that speeds up the code)
• Bug fix (non-breaking change which fixes an issue)

Key checklist:

• No style issues: $ flake8
• All tests pass: $ python run-tests.py --unit
• The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

• Code is commented, particularly in hard-to-understand areas
• Tests added that prove fix is effective or that feature works

[codecov]

Codecov Report

Merging #1086 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1086      +/-   ##
===========================================
- Coverage    97.78%   97.78%   -0.01%     
===========================================
  Files          242      242              
  Lines        12662    12658       -4     
===========================================
- Hits         12381    12377       -4     
  Misses         281      281              

Impacted Files	Coverage Δ
pybamm/solvers/casadi_solver.py	100.00% <ø> (ø)
pybamm/simulation.py	98.01% <100.00%> (-0.04%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc2204a...5333fba. Read the comment docs.

[valentinsulzer]

Thanks Rob, looks great!

[valentinsulzer]

Played around a little bit with this and I think we should suggest something closer to 3600 (e.g. 3700)