Issue 1082 casadi - #1089
Merged
Merged
Conversation
brosaplanella
approved these changes
Jun 30, 2020
brosaplanella
left a comment
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks Tino!
rtimms
approved these changes
Jun 30, 2020
rtimms
left a comment
rtimms
left a comment
Contributor
There was a problem hiding this comment.
thanks @tinosulzer looks good, just a small comment re the error raised
| ) | ||
| "Maximum number of decreased steps occurred at t={}. Try " | ||
| "solving the model up to this time only or reducing dt_max." | ||
| "".format(t) |
Contributor
There was a problem hiding this comment.
should we give the dimensional time in the error to make it easier for people to pass to t_eval. similar comment for dt_max
Codecov Report
@@ Coverage Diff @@
## develop #1089 +/- ##
========================================
Coverage 97.78% 97.78%
========================================
Files 242 242
Lines 12660 12662 +2
========================================
+ Hits 12379 12381 +2
Misses 281 281
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some small changes to the casadi solver, particularly adding the events to the solution. Leaving the issue open as there is other stuff to do
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: