Issue 1104 mass matrix for bdf#1107
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1107 +/- ##
========================================
Coverage 97.81% 97.82%
========================================
Files 245 245
Lines 13179 13269 +90
========================================
+ Hits 12891 12980 +89
- Misses 288 289 +1
Continue to review full report at Codecov.
|
08d811b to
ec0ab2b
Compare
ec0ab2b to
107f7ce
Compare
… semi-explicit dae models
valentinsulzer
left a comment
There was a problem hiding this comment.
Thanks @martinjrobins , this looks great! Could you add the jax solver to the compare-dae-solvers.py example?
So goes doing jax.grad do adjoint sensitivities for you?
We should coordinate how the sensitivity API will work, let's discuss this on the PR for sensitivity for the casadi solver that I will open soon
|
yes, we should iterate on the API, I just put in something temporary for now. The solver can return a pure solve function that takes in inputs and returns a solution ndarray. This can then be differentiated using I've added in the jax solver to |
|
Ah ok, yeah 11 minutes to run an example isn't great, perhaps shouldn't include it in that light. Thanks for the info re: sensitivities :) |
This reverts commit 1cd40f8.
Description
Fixes #1104
Type of change
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: