Repository navigation
Issue 1127 extra notebooks - #1131
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1131 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 247 247
Lines 13910 13911 +1
========================================
+ Hits 13622 13623 +1
Misses 288 288
Continue to review full report at Codecov.
|
brosaplanella
left a comment
There was a problem hiding this comment.
Just two minor comments but looks good to me. Thanks Rob!
| $ jupyter notebook | ||
| ``` | ||
| from your local PyBaMM repository, or used online through [Binder](https://mybinder.org/v2/gh/pybamm-team/PyBaMM/master), or you can simply copy/paste the relevant code. | ||
| from your local PyBaMM repository, or used online through [Google Colab](https://colab.research.google.com/github/pybamm-team/PyBaMM/blob/master/) or [Binder](https://mybinder.org/v2/gh/pybamm-team/PyBaMM/master). Alternatively, you can simply copy/paste the relevant code. |
There was a problem hiding this comment.
Are we using Binder? I removed it because I thought we weren't but happy to keep it.
There was a problem hiding this comment.
I've removed it. I think the link still works, but Colab is better
| "source": [ | ||
| "# Tutorial 9 - Changing the mesh\n", | ||
| "\n", | ||
| "In [Tutorial 8](./Tutorial%207%20-%20Solver%20options.ipynb) we saw how to change the solver options. In this tutorial we will change the mesh used in the simulation, and, as in the solver options tutorial, show how to do a graphical mesh refinement study.\n", |
There was a problem hiding this comment.
At the end we didn't show how to do a graphical convergence study so we should change this sentence.
There was a problem hiding this comment.
thanks, I've updated this
Description
Fixes some of #1127
Leaving #1127 open as I still think we should add details of the DFN in dimensional form and add a table or similar giving the string names for the parameters (at least for the basic DFN).
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: