Fix half cell bug - #1133
Merged
valentinsulzer merged 3 commits intoAug 27, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1133 +/- ##
===========================================
+ Coverage 97.90% 97.92% +0.02%
===========================================
Files 246 247 +1
Lines 13572 13913 +341
===========================================
+ Hits 13287 13625 +338
- Misses 285 288 +3
Continue to review full report at Codecov.
|
rtimms
approved these changes
Aug 27, 2020
Contributor
|
thanks @ferranbrosa ! could you update the changelog too |
Member
Author
Done! I was about to do so, you are too efficient hahaha |
Contributor
|
haha always waiting for the next PR to turn up! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the bug with the potential on half-cell models
Fixes #1132
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: