Skip to content

Added example conservation - #1186

Merged
valentinsulzer merged 3 commits into
pybamm-team:developfrom
brosaplanella:issue-1185-example-conservation
Oct 14, 2020
Merged

Added example conservation#1186
valentinsulzer merged 3 commits into
pybamm-team:developfrom
brosaplanella:issue-1185-example-conservation

Conversation

@brosaplanella

@brosaplanella brosaplanella commented Oct 12, 2020

Copy link
Copy Markdown
Member

Description

Added an example script for lithium conservation.

Fixes #1185

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas

@brosaplanella
brosaplanella requested a review from rtimms October 12, 2020 16:07
@brosaplanella

Copy link
Copy Markdown
Member Author

Does this need a CHANGELOG entry?

@rtimms

rtimms commented Oct 13, 2020

Copy link
Copy Markdown
Contributor

thanks @ferranbrosa ! I guess you could add that there is a new example to the changelog, but no big deal if not.

@valentinsulzer
valentinsulzer merged commit 9aa93b8 into pybamm-team:develop Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add example script conservation of lithium

3 participants