Repository navigation
Add ECM variables - #1204
Merged
Merged
Add ECM variables#1204
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1204 +/- ##
========================================
Coverage 97.93% 97.93%
========================================
Files 247 247
Lines 14024 14036 +12
========================================
+ Hits 13734 13746 +12
Misses 290 290
Continue to review full report at Codecov.
|
rtimms
requested changes
Oct 21, 2020
rtimms
left a comment
Contributor
There was a problem hiding this comment.
looks good thanks, would you be able to reorganize this a little so that all the ECM variables are defined together and just add a short comment explaining them (its not obvious as we have no other ECM stuff in pybamm)
rtimms
approved these changes
Oct 22, 2020
Contributor
Author
|
@rtimms why failing on mac? I'm not authorized to merge this so please do so if you're ready. Thanks |
Member
|
Everything is failing on mac right now. We need to wait for github to fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Some extra variables for the ecm model based on using pybamm in an external equivalent circuit model
Fixes # (issue)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: