fix sim.t_eval when timescale is function of input#1218
Merged
Conversation
rtimms
approved these changes
Oct 29, 2020
rtimms
left a comment
Contributor
There was a problem hiding this comment.
thanks @TomTranter , don't forget to update the changelog
Codecov Report
@@ Coverage Diff @@
## develop #1218 +/- ##
========================================
Coverage 97.92% 97.92%
========================================
Files 249 249
Lines 14146 14146
========================================
Hits 13852 13852
Misses 294 294
Continue to review full report at Codecov.
|
Contributor
Author
|
Didn't realize we had a changelog! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Use evaluated timescale from solution when doing sim solve
Fixes #1217
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: