Issue 1230 simplify #1252
Merged
Issue 1230 simplify #1252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brosaplanella
approved these changes
Nov 17, 2020
Member
brosaplanella
left a comment
brosaplanella
left a comment
There was a problem hiding this comment.
Looks good to me, just a typo to fix. Thanks Tino!
| self.assertEqual(av_a.children[0].integration_variable[0].domain, x.domain) | ||
| self.assertEqual(av_a.domain, []) | ||
|
|
||
| # whole electrode domain is different as the divisioni by 1 gets simplified out |
Codecov Report
@@ Coverage Diff @@
## develop #1252 +/- ##
===========================================
+ Coverage 97.99% 98.05% +0.05%
===========================================
Files 264 264
Lines 14748 14841 +93
===========================================
+ Hits 14453 14552 +99
+ Misses 295 289 -6
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
Nov 23, 2020
Member
brosaplanella
left a comment
brosaplanella
left a comment
There was a problem hiding this comment.
Looks great, thanks Tino! Great job :)
rtimms
approved these changes
Nov 24, 2020
pybamm/expression_tree/symbol.py
Outdated
| else: | ||
| return False | ||
| return self.shape_for_testing == () | ||
| # result = self.evaluate_ignoring_errors() |
Contributor
There was a problem hiding this comment.
can this commented code be removed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Automatically simplify expressions that can be simplified, e.g.
1*xbecomesx.This can be bypassed by creating the binary operator explicitly, e.g.
pybamm.Multiplication(1, x)Fixes #1230
Fixes #986
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: