#1251 fix function parameter diff bug#1294
Merged
Merged
Conversation
valentinsulzer
marked this pull request as draft
December 11, 2020 21:05
Codecov Report
@@ Coverage Diff @@
## develop #1294 +/- ##
========================================
Coverage 98.15% 98.15%
========================================
Files 272 272
Lines 15600 15622 +22
========================================
+ Hits 15312 15334 +22
Misses 288 288
Continue to review full report at Codecov.
|
valentinsulzer
marked this pull request as ready for review
February 2, 2021 20:32
Member
Author
|
Coverage error is something that was already failing before ... |
brosaplanella
approved these changes
Feb 3, 2021
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good to me, thanks Tino!
| # the NotConstant class | ||
| # to differentiate it from the electrolyte concentration inside the | ||
| # surface potential difference when taking j.diff(c_e) later on | ||
| # use explicit Multiplication instead of * to avoid simplification |
Member
There was a problem hiding this comment.
Can this line be removed now?
…51-diff-function-parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1251
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: