Skip to content

Issue 1322 thermal parameters dependent temperature#1323

Merged
brosaplanella merged 11 commits into
pybamm-team:developfrom
brosaplanella:issue-1322-thermal-parameters-dependent-temperature
Jan 13, 2021
Merged

Issue 1322 thermal parameters dependent temperature#1323
brosaplanella merged 11 commits into
pybamm-team:developfrom
brosaplanella:issue-1322-thermal-parameters-dependent-temperature

Conversation

@brosaplanella
Copy link
Copy Markdown
Member

@brosaplanella brosaplanella commented Jan 11, 2021

Description

The thermal parameters (density, heat capacity and conductivity) can now be functions of temperature.

Fixes #1322

Type of change

Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.

  • New feature (non-breaking change which adds functionality)

Key checklist:

  • No style issues: $ flake8
  • All tests pass: $ python run-tests.py --unit
  • The documentation builds: $ cd docs and then $ make clean; make html

You can run all three at once, using $ python run-tests.py --quick.

Further checks:

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2021

Codecov Report

Merging #1323 (7567868) into develop (85b3a20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1323   +/-   ##
========================================
  Coverage    98.12%   98.12%           
========================================
  Files          272      272           
  Lines        15380    15431   +51     
========================================
+ Hits         15091    15142   +51     
  Misses         289      289           
Impacted Files Coverage Δ
pybamm/models/submodels/thermal/lumped.py 100.00% <ø> (ø)
...mal/pouch_cell/pouch_cell_1D_current_collectors.py 100.00% <ø> (ø)
...mal/pouch_cell/pouch_cell_2D_current_collectors.py 100.00% <ø> (ø)
pybamm/models/submodels/thermal/x_full.py 100.00% <100.00%> (ø)
pybamm/parameters/lead_acid_parameters.py 100.00% <100.00%> (ø)
pybamm/parameters/lithium_ion_parameters.py 100.00% <100.00%> (ø)
pybamm/parameters/thermal_parameters.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85b3a20...7567868. Read the comment docs.

Comment thread pybamm/models/submodels/thermal/x_full.py
Comment thread pybamm/parameters/lead_acid_parameters.py
Copy link
Copy Markdown
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @brosaplanella , just a couple of things to change / clarify

Comment thread pybamm/models/submodels/thermal/x_full.py
Comment thread pybamm/parameters/lithium_ion_parameters.py
Comment thread pybamm/parameters/thermal_parameters.py Outdated
Copy link
Copy Markdown
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Each dimensionless function should calculate T_dim from T and then pass this to the dimensional function

Comment thread pybamm/parameters/lithium_ion_parameters.py
Comment thread pybamm/parameters/thermal_parameters.py Outdated

def rho_cn(self, T):
"Dimensionless negative current collector density"
return self.rho_cn_dim(T) * self.c_p_cn_dim(T) / self.rho_eff_dim(self.T_ref)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to make T dimensional here and pass T_dim to the functions

Copy link
Copy Markdown
Member

@valentinsulzer valentinsulzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, all good now

@brosaplanella brosaplanella merged commit 77e0767 into pybamm-team:develop Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make thermal parameters a function of temperature

2 participants