Rename cathode and anode - #1337
Merged
brosaplanella merged 17 commits intoJan 27, 2021
Merged
Conversation
valentinsulzer
left a comment
Member
There was a problem hiding this comment.
We should discuss in the meeting that this is not too much of a breaking change. But the changes themselves are all good
valentinsulzer
approved these changes
Jan 25, 2021
valentinsulzer
left a comment
Member
There was a problem hiding this comment.
Looks good, just a suggestion for an extra error check
… provided (same for cathode)
brosaplanella
commented
Jan 26, 2021
| if "sei" in chemistry: | ||
| component_groups += ["sei"] | ||
|
|
||
| if "anode" in chemistry.keys(): |
Member
Author
There was a problem hiding this comment.
@tinosulzer @tlestang here are the warnings/errors you suggested, in case you want to take a look. Otherwise, let me know and I will merge the branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Notation has been homogenised to use positive and negative electrode (instead of cathode and anode). This applies to the options in the cracking model and lost of active material and the parameter folders.
Fixes #1333
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: