Repository navigation
Issue 1405 xaverage - #1490
Merged
Merged
Issue 1405 xaverage#1490
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1490 +/- ##
========================================
Coverage 98.31% 98.32%
========================================
Files 295 294 -1
Lines 16783 16854 +71
========================================
+ Hits 16500 16571 +71
Misses 283 283
Continue to review full report at Codecov.
|
rtimms
approved these changes
May 24, 2021
rtimms
left a comment
Contributor
There was a problem hiding this comment.
neat! thanks, @tinosulzer !
|
|
||
| def __init__(self, options=None, name="Doyle-Fuller-Newman model", build=True): | ||
| super().__init__(options, name) | ||
| self.x_average = False |
Contributor
There was a problem hiding this comment.
might be worth a comment here explaining why x_average is True/False for different models (just in dfn, spm etc., not in every submodel)
| return variables | ||
|
|
||
| def set_rhs(self, variables): | ||
| Domain = self.domain + " electrode" |
Contributor
There was a problem hiding this comment.
very minor style point, but odd for this to be capitalized. I guess to distinguish from self.domain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Reformats the degradation models so that the x-averaged form can be used
Adds a reaction-driven LAM model from Reniers 2019
Fixes #1405
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: