Add BaseParameters and SymPy - #1495
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1495 +/- ##
========================================
Coverage 98.34% 98.34%
========================================
Files 295 296 +1
Lines 17093 17104 +11
========================================
+ Hits 16810 16821 +11
Misses 283 283
Continue to review full report at Codecov.
|
valentinsulzer
left a comment
There was a problem hiding this comment.
BaseParameters class looks good but test needs changing. In general it is best for unit tests to call the least number of methods possible (i.e. not require on other things not changing).
Also can you add the "GSOC21: print equations" label on the rhs? Or do you not have permissions to do that?
|
@tinosulzer I do not have the permission to add labels |
valentinsulzer
left a comment
There was a problem hiding this comment.
Thanks @priyanshuone6 , I'll add the label for now and look into how to get you access
|
Also please update the CHANGELOG.md with your changes |
|
Thanks @tinosulzer |
Description
(GSoC21: Print Equations)
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: