-
-
Notifications
You must be signed in to change notification settings - Fork 643
Add BatchStudy
examples
#1747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BatchStudy
examples
#1747
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1747 +/- ##
========================================
Coverage 99.28% 99.28%
========================================
Files 343 343
Lines 18864 18868 +4
========================================
+ Hits 18729 18733 +4
Misses 135 135
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks! I think you can also do the quick fix for #1745 ?
Yes, should I add a "breaking change" for renaming |
input_solutions = solutions
solutions = [] then |
thanks for fixing my mess haha |
Description
Added an example notebook describing
pybamm.BatchStudy
. The notebook compares models, parameter values, and summary variables. Please let me know if there are some other interesting comparisons that I should add in here.Fixes #1492
Fixes #1745
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8
$ python run-tests.py --unit
$ cd docs
and then$ make clean; make html
You can run all three at once, using
$ python run-tests.py --quick
.Further checks: