Issue 1726 sumvar#1760
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1760 +/- ##
========================================
Coverage 99.28% 99.28%
========================================
Files 343 343
Lines 18900 18921 +21
========================================
+ Hits 18765 18786 +21
Misses 135 135
Continue to review full report at Codecov.
|
brosaplanella
approved these changes
Oct 27, 2021
brosaplanella
left a comment
Member
There was a problem hiding this comment.
Looks good, thanks Tino!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add
model.summary_variablesso that the user can set which summary variables they want. This also makes the half-cell model and lead-acid models compatible with experiments.Fixes #1726
Type of change
Please add a line in the relevant section of CHANGELOG.md to document the change (include PR #) - note reverse order of PR #s. If necessary, also add to the list of breaking changes.
Key checklist:
$ flake8$ python run-tests.py --unit$ cd docsand then$ make clean; make htmlYou can run all three at once, using
$ python run-tests.py --quick.Further checks: